RE: [PATCH 08/24] fas216: Update logging messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Hannes Reinecke [mailto:hare@xxxxxxx]
...
> @@ -2079,12 +2078,12 @@ fas216_std_done(FAS216_Info *info, struct scsi_cmnd
> *SCpnt, unsigned int result)
>  			break;
> 
>  		default:
> -			printk(KERN_ERR "scsi%d.%c: incomplete data transfer "
> -				"detected: res=%08X ptr=%p len=%X CDB: ",
> -				info->host->host_no, '0' + SCpnt->device->id,
> -				SCpnt->result, info->scsi.SCp.ptr,
> -				info->scsi.SCp.this_residual);
> -			__scsi_print_command(SCpnt->cmnd);
> +			scmd_printk(KERN_ERR, SCpnt,
> +				    "incomplete data transfer "
> +				    "detected: res=%08X ptr=%p len=%X\n",

checkpatch lets you keep strings on one line even if the code
exceeds 80 characters.

> +				    SCpnt->result, info->scsi.SCp.ptr,
> +				    info->scsi.SCp.this_residual);
> +			scsi_print_command(SCpnt);
>  			set_host_byte(SCpnt, DID_ERROR);
>  			goto request_sense;
>  		}
> @@ -2157,12 +2156,12 @@ static void fas216_done(FAS216_Info *info, unsigned
> int result)
>  	 * to transfer, we should not have a valid pointer.
>  	 */
>  	if (info->scsi.SCp.ptr && info->scsi.SCp.this_residual == 0) {
> -		printk("scsi%d.%c: zero bytes left to transfer, but "
> -		       "buffer pointer still valid: ptr=%p len=%08x CDB: ",
> -		       info->host->host_no, '0' + SCpnt->device->id,
> -		       info->scsi.SCp.ptr, info->scsi.SCp.this_residual);
> +		scmd_printk(KERN_INFO, SCpnt,
> +			    "zero bytes left to transfer, but "
> +			    "buffer pointer still valid: ptr=%p len=%08x\n",

checkpatch lets you keep strings on one line even if the code
exceeds 80 characters.


---
Rob Elliott    HP Server Storage



--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux