On Tue, Sep 30, 2014 at 01:50:36PM +0200, Hannes Reinecke wrote:
> Update logging messages to use dev_printk() variants for correct
> device annotations.
> - printk(" CDB: ");
> - __scsi_print_command(SCpnt->cmnd);
> + scsi_print_command(SCpnt);
And a __scsi_print_command -> scsi_print_command switch. Which is
fine, but sould be mentioned.
> - SCpnt->result &= ~(255 << 16);
> - SCpnt->result |= DID_BAD_TARGET << 16;
> + scmd_printk(KERN_ERR, SCpnt,
> + "incomplete data transfer "
> + "detected: res=%08X ptr=%p len=%X\n",
> + SCpnt->result, info->scsi.SCp.ptr,
> + info->scsi.SCp.this_residual);
> + scsi_print_command(SCpnt);
> + set_host_byte(SCpnt, DID_ERROR);
But the canges to setting ->result really do not belong into this
series. I'll happily take them as a separate patch, though.
With that bit removed:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
