On Fri, Sep 26, 2014 at 10:36 AM, Chen Gang <gang.chen.5i5j@xxxxxxxxx> wrote: > When xenbus_switch_state() fails, it will call xenbus_switch_fatal() > internally, so need not return any status value, then use 'void' instead > of 'int' for xenbus_switch_state() and __xenbus_switch_state(). > > Also need be sure that all callers which check the return value must let > 'err' be 0. > > And also need change the related comments for xenbus_switch_state(). > > Signed-off-by: Chen Gang <gang.chen.5i5j@xxxxxxxxx> > --- > drivers/block/xen-blkback/xenbus.c | 9 ++------- > drivers/net/xen-netback/xenbus.c | 5 +---- > drivers/pci/xen-pcifront.c | 15 ++++++--------- > drivers/xen/xen-pciback/xenbus.c | 21 ++++----------------- > drivers/xen/xen-scsiback.c | 5 +---- > drivers/xen/xenbus/xenbus_client.c | 16 ++++++++-------- > include/xen/xenbus.h | 3 ++- > 7 files changed, 24 insertions(+), 50 deletions(-) I don't know enough to review this, but as far as I'm concerned, the Xen folks own drivers/pci/xen-pcifront.c, so whatever they want to do is fine with me. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
