On 09/22/2014 03:44 PM, Chris J Arges wrote: > When using a virtual SCSI disk in a VMWare VM if blkdev_issue_zeroout is used > data can be improperly zeroed out using the mptfusion driver. This patch > disables write_same for this driver and the vmware subsystem_vendor which > ensures that manual zeroing out is used instead. > > BugLink: http://bugs.launchpad.net/bugs/1371591 > Reported-by: Bruce Lucas <bruce.lucas@xxxxxxxxxxx> > Tested-by: Chris J Arges <chris.j.arges@xxxxxxxxxxxxx> > Signed-off-by: Chris J Arges <chris.j.arges@xxxxxxxxxxxxx> > --- > drivers/message/fusion/mptspi.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/message/fusion/mptspi.c b/drivers/message/fusion/mptspi.c > index 787933d..fca1594 100644 > --- a/drivers/message/fusion/mptspi.c > +++ b/drivers/message/fusion/mptspi.c > @@ -1409,6 +1409,12 @@ mptspi_probe(struct pci_dev *pdev, const struct pci_device_id *id) > return 0; > } > > + /* Fix for vmware guests that do not implement write_same > + */ > + if (pdev->subsystem_vendor == 0x15AD) { > + mptspi_driver_template.no_write_same = 1; > + } > + > sh = scsi_host_alloc(&mptspi_driver_template, sizeof(MPT_SCSI_HOST)); > > if (!sh) { > This is a do-no-harm patch, with a case to check for vmware subsystem_vendor as suggested by Christoph. Let me know if there are issues with this patch (do I need a define for the vendor ID? Is the comment a little too vague or unnecessary?) Adding those that were CC'ed in the other part of the thread. Thanks, --chris j arges -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
