On Sat, Sep 13, 2014 at 01:07:11AM +0000, Elliott, Robert (Server Storage) wrote: > > I've not seen an answer to my question in reply to the previous version > > of this. Why would you do pretty printing of a variable that can just > > return SUCCESS or FAILURE? > > Is there anything prohibiting the scsi_eh_abort_handler provided by > the LLD from returning any of the other values like NEEDS_RETRY? Right now there is nothing prohibiting them from returning any possible value, but we only handle SUCCESS specially and treat everything else as FAILED. If anyone is motivated enough to make this cleaner we should add a WARN_ON for any other value as it's a driver bug. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html