On Wed, Sep 10, 2014 at 02:54:09PM +0300, Dolev Raviv wrote: > From: Subhash Jadavani <subhashj@xxxxxxxxxxxxxx> > > SCSI Well-known logical units generally don't have any scsi driver > associated with it which means no one will call scsi_autopm_put_device() > on these wlun scsi devices and this would result in keeping the > corresponding scsi device always active (hence LLD can't be suspended as > well). Same exact problem can be seen for other scsi device representing > normal logical unit whose driver is yet to be loaded. This patch fixes > the above problem with this approach: > > - make the scsi_autopm_put_device call at the end of scsi_sysfs_add_sdev > to make it balance out the get earlier in the function. > - let drivers do paired get/put calls in their probe methods. > > Signed-off-by: Subhash Jadavani <subhashj@xxxxxxxxxxxxxx> > Signed-off-by: Dolev Raviv <draviv@xxxxxxxxxxxxxx> Looks good to me, I will pick this up for the next core-for-3.18 update. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
