>>>>> "Sagi" == Sagi Grimberg <sagig@xxxxxxxxxxxxxxxxxx> writes: Sagi, Sagi> That's still a dependence on prot_type (type 0...). Notice that Sagi> you set SCSI_PROT_REF_INCREMENT in every op index (except Sagi> SCSI_PROT_NORMAL) so my point is that it's strange to see this Sagi> association. I still don't understand your point. The mask table indicates which flags are valid for a given protection operation. They are explicitly DIX flags and have nothing to do with the target protection type. Sagi> P.S. Now drivers can stop understanding prot_type to set DIF Sagi> operations... so once drivers stop referencing it we can remove Sagi> it from scsi_cmnd. Yes. Second part of this installment removes this and a few other things and converts qla2xxx, lpfc, mptNsas, etc. to the new interface. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html