On Thu, Sep 11, 2014 at 3:02 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Wed, Sep 10, 2014 at 09:40:11AM +0800, Ming Lei wrote: >> I am wondering we can do that because lifetime is totally different >> between flush requests and tag_set requests which are initialized >> before request queue is created. > > We shouldn't do it in the tag sets, but where we allocate and free > each hctx: blk_mq_init_queue and blk_mq_free_hw_queues. That should work, but both flush queue's allocation and .init_request() have to move to the function because hctx->numa_node is basically ready in blk_mq_init_queue(). Then blk_init_flush() only need to allocate the data for legacy case. Thanks, -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
