On 09/10/2014 12:09 PM, Christoph Hellwig wrote: > On Wed, Sep 10, 2014 at 10:47:49AM -0600, Jens Axboe wrote: >> BTW, please don't mix up the REQ_END and ->queue_rq() changes with the >> changed start_request API. > > I have to. It's set by start_request, so we need to pass down the last > argument to keep the old behavior. And once we pass the argument we > can just it directly. It could still be done in the caller, but arguably, you'd have to do it twice unless the ->queue_rq() call was rolled into a function. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html