Hello, Alan. On Tue, Sep 09, 2014 at 11:08:22AM -0400, Alan Stern wrote: > Sorry, the meaning wasn't clear. I meant that the existing code > doesn't work. The patch seems to work okay (except that I can't use > queue_flag_test_and_set because the queue isn't locked at that point). > I'll submit the patch shortly. Given it's fully synchronized, the following should work fine and probably is less misleading than using atomic test_and_set. if (!blk_queue_init_done) { queue_flag_set_unlocked(QUEUE_FLAG_INIT_DONE, q); blk_queue_bypass_end(q); } Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html