On 09/08/2014 10:55 AM, Ming Lei wrote: > On Mon, Sep 8, 2014 at 2:49 AM, Christoph Hellwig <hch@xxxxxx> wrote: >> This works fine for me, although I still don't really like it very much. >> >> If you really want to go down the path of major surgery in this area we >> should probably allocate a flush request per hw_ctx, and initialize it >> using the normal init/exit functions. If we want to have proper multiqueue >> performance on devices needing flushes we'll need something like that anyway. > > Yes, that should be the final solution for the problem, and looks the whole > flush machinery need to move into hctx, I will try to figure out one patch to > do that. I had not thought of that, but seems like a great way to clean this up a lot. It just never felt like the right thing to do. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html