On Fri, Sep 05, 2014 at 10:24:40AM +0900, Yoshihiro YUNOMAE wrote: > > #define SA_NAME_LIST_SZ ARRAY_SIZE(sa_names_arr) > > We can delete SA_NAME_LIST_SZ because we define it out of > CONFIG_SCSI_CONSTANTS. I'd generally prefer to just use ARRAY_SIZE() directly instead of adding another layer of indirection. Otherwise looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html