On 09/05/2014 08:37 AM, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx> > > Its reported that mptsas can at times take over 30 seconds > to recognize SCSI storage devices [0], this is done on the > driver's probe path. Use the the new asynch probe to > circumvent systemd from killing this driver. > > [0] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1276705 > > Cc: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx> > Cc: Joseph Salisbury <joseph.salisbury@xxxxxxxxxxxxx> > Cc: One Thousand Gnomes <gnomes@xxxxxxxxxxxxxxxxxxx> > Cc: Tim Gardner <tim.gardner@xxxxxxxxxxxxx> > Cc: Pierre Fersing <pierre-fersing@xxxxxxxxxxx> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Cc: Oleg Nesterov <oleg@xxxxxxxxxx> > Cc: Benjamin Poirier <bpoirier@xxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: Nagalakshmi Nandigama <nagalakshmi.nandigama@xxxxxxxxxxxxx> > Cc: Praveen Krishnamoorthy <praveen.krishnamoorthy@xxxxxxxxxxxxx> > Cc: Sreekanth Reddy <sreekanth.reddy@xxxxxxxxxxxxx> > Cc: Abhijit Mahajan <abhijit.mahajan@xxxxxxxxxxxxx> > Cc: Hariprasad S <hariprasad@xxxxxxxxxxx> > Cc: Santosh Rastapur <santosh@xxxxxxxxxxx> > Cc: Casey Leedom <leedom@xxxxxxxxxxx> > Cc: MPT-FusionLinux.pdl@xxxxxxxxxxxxx > Cc: linux-scsi@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > Cc: netdev@xxxxxxxxxxxxxxx > Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxx> > --- > drivers/message/fusion/mptsas.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c > index 0707fa2..6dfee95 100644 > --- a/drivers/message/fusion/mptsas.c > +++ b/drivers/message/fusion/mptsas.c > @@ -5385,6 +5385,7 @@ static struct pci_driver mptsas_driver = { > .suspend = mptscsih_suspend, > .resume = mptscsih_resume, > #endif > + .driver.async_probe = true, > }; > > static int __init > This is the wrong appoach. First of all, the mptsas, mpt2sas, and mpt3sas all share the same driver layout, so any issue happeing with this driver will most likely affect the others, too. Secondly the driver is event-based anyway, so we should be moving the initialisation to the already existing event handler: diff --git a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c index 0707fa2..6f41e2c 100644 --- a/drivers/message/fusion/mptsas.c +++ b/drivers/message/fusion/mptsas.c @@ -5305,7 +5305,7 @@ mptsas_probe(struct pci_dev *pdev, const struct pci_device_id *id) /* older firmware doesn't support expander events */ if ((ioc->facts.HeaderVersion >> 8) < 0xE) ioc->old_sas_discovery_protocal = 1; - mptsas_scan_sas_topology(ioc); + mptsas_queue_rescan(ioc); mptsas_fw_event_on(ioc); return 0; -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
