On 09/01/2014 12:29 AM, Christoph Hellwig wrote: > On Thu, Aug 28, 2014 at 07:33:36PM +0200, Hannes Reinecke wrote: >> There is no need to print out the command result verbatim; >> that will be done by the scsi stack if required. >> Here we just should log the result in short if requested. > > Is there any good reason to keep this logging in sd at all? > Mainly orthogonality. SCSI_LOG_HL(QUEUE|COMPLETE) is meant for ULDs to print out some extra logging. So as sd.c already uses SCSI_LOG_HLQUEUE to print information about I/O start it should also be using SCSI_LOG_HLCOMPLETE upon I/O finish. And should preferable record the same information at both instances so that any admin can match them together. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
