Re: [PATCH 12/22] scsi: remove obsolete __scsi_print_command() usages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Can you change the subject a bit?  There's nothing obsolete in
__scsi_print_command, you're just moving it to a higher level helper.

>  #if defined(AHA152X_DEBUG)
>  	if (HOSTDATA(shpnt)->debug & debug_queue) {
> -		printk(INFO_LEAD "queue: %p; cmd_len=%d pieces=%d size=%u cmnd=",
> -		       CMDINFO(SCpnt), SCpnt, SCpnt->cmd_len,
> -		       scsi_sg_count(SCpnt), scsi_bufflen(SCpnt));
> -		__scsi_print_command(SCpnt->cmnd);
> +		scmd_printk(KERN_INFO, SCpnt,
> +			    "queue: %p; cmd_len=%d pieces=%d size=%u\n",
> +			    SCpnt, SCpnt->cmd_len,
> +			    scsi_sg_count(SCpnt), scsi_bufflen(SCpnt));
> +		scsi_print_command(SCpnt);

This also has a printk -> scmd_printk change that's unrelated to the
patch.

Honestly I think we should just kill much of the AHA152X_DEBUG code at
the start of this series to avoid all the churn in it.

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux