> -scsi_extd_sense_format(unsigned char asc, unsigned char ascq) { > +scsi_extd_sense_format(unsigned char asc, unsigned char ascq, > + const char **fmt) { please move the opening brace to a new line per normal Linux style. Otherwise looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html