On Sun, 24 Aug 2014, Christoph Hellwig wrote: > On Fri, Aug 22, 2014 at 01:29:32PM -0400, Alan Stern wrote: > > > Other than this, I'm fine with the code ... you can add the acked by > > > from me when we resolve the above question. > > > > Okay. It's true that this issue is only tangentially related to the > > main point of the patch. It could be removed and addressed later. > > Just make it a separate patch and send it along.. All right. But I still want to know first whether the patch really fixes the original problem. Tiziano, do you intend to test this patch? James, can you explain how the INQUIRY command in scsi_probe_lun() managed to work back in the days when multi-lun SCSI-2 devices were common? sdev->scsi_level doesn't get set when sdev is allocated, so it initially contains 0, so the LUN bits won't get filled in when the first INQUIRY command is sent. Then how could the target know which logical unit the INQUIRY was meant for? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
