On Tue, Aug 05, 2014 at 04:10:08PM +0300, Ari Sundholm wrote: > > On Mon, 4 Aug 2014, Christoph Hellwig wrote: > > > To modify the timeout on a queue please use blk_queue_rq_timeout in > > the slave_configure method instead of poking directly into the block > > timer, which won't work e.g. for the blk-mq path. > > I see. It seems the way the driver Areca offers on its download page does > this is wrong, then, as all I did was I ported the feature from there. > > > But this really needs an explanation on why you'd need a configurable > > timeout to start with. > > A colleague of mine has experienced problems with disks not supporting > TLER performing lengthy error recovery, hitting a timeout. He has > mitigated this problem by configuring the timeout to be long enough to > allow for the error recovery to finish. And again, the driver offered by > Areca supports this feature, so it seems they have their reasons as well. Can you test this patch: http://git.infradead.org/users/hch/scsi-queue.git/commitdiff/3a7fcf9e5f57469fab78d6b6db81fbef6fa48a0d which is part of the latest Areca code drop? I don't really like the timeout parameter, but if there's no better work around for you we'll probablyneed to merge something. In that case I'd love a patch ontop of the branch that the above patches is in, which used the timeout manipulation method I mentioned in my previous mail. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
