Hi Ewan,
Thank you for your review.
(2014/08/16 0:05), Ewan Milne wrote:
On Fri, 2014-08-08 at 11:50 +0000, Yoshihiro YUNOMAE wrote:
All bytes in CDB should be output after linebuf is filled because
"[%s] CDB: %s\n" message is output many times in loop.
Signed-off-by: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@xxxxxxxxxxx>
Cc: Hannes Reinecke <hare@xxxxxxx>
Cc: Doug Gilbert <dgilbert@xxxxxxxxxxxx>
Cc: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
Cc: Christoph Hellwig <hch@xxxxxx>
Cc: "James E.J. Bottomley" <JBottomley@xxxxxxxxxxxxx>
Cc: Hidehiro Kawai <hidehiro.kawai.ez@xxxxxxxxxxx>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
---
drivers/scsi/constants.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/constants.c b/drivers/scsi/constants.c
index 9c38b8d..5956d4d 100644
--- a/drivers/scsi/constants.c
+++ b/drivers/scsi/constants.c
@@ -413,9 +413,8 @@ void __scsi_print_command(struct scsi_device *sdev, const char *prefix,
hex_dump_to_buffer(cdb + i, linelen, 16, 1,
linebuf, sizeof(linebuf), false);
- sdev_printk(KERN_INFO, sdev, "[%s] CDB: %s\n",
- prefix, linebuf);
}
+ sdev_printk(KERN_INFO, sdev, "[%s] CDB: %s\n", prefix, linebuf);
}
EXPORT_SYMBOL(__scsi_print_command);
This doesn't look right -- In Hannes' tree what the code is doing is
printing out a separate line for each 16 bytes of the CDB. You change
will cause only the last (partial?) 16 bytes to be printed.
Ah, that's true. We should not apply this patch.
Thanks,
Yoshihiro YUNOMAE
--
Yoshihiro YUNOMAE
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: yoshihiro.yunomae.ez@xxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
