On Mon, Jul 28, 2014 at 11:26:13AM +0530, Kashyap Desai wrote: > > -----Original Message----- > > From: Alexander Gordeev [mailto:agordeev@xxxxxxxxxx] > > Sent: Saturday, July 26, 2014 1:54 PM > > To: linux-kernel@xxxxxxxxxxxxxxx; Neela Syam Kolli > > Subject: Re: [PATCH v2 RESEND 13/23] megaraid: Fail resume if MSI-X re- > > initialization failed > > > > On Wed, Jul 16, 2014 at 08:05:17PM +0200, Alexander Gordeev wrote: > > > Currently the driver fails to analize MSI-X re-enablement status on > > > resuming and always assumes the success. This update checks the MSI-X > > > initialization result and fails to resume if MSI-Xs re-enablement > > > failed. > > > > Hi Neela, > > > > Could you please review megaraid patches in this series? > > > > Thanks! > Please consider this patch Acked by Me. > > Acked-by: Kashyap Desai <Kashyap.desai@xxxxxxxxxxxxx> Christoph, I guess, this patch could be picked? > > > > > Signed-off-by: Alexander Gordeev <agordeev@xxxxxxxxxx> > > > --- > > > drivers/scsi/megaraid/megaraid_sas_base.c | 8 +++++--- > > > 1 files changed, 5 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c > > > b/drivers/scsi/megaraid/megaraid_sas_base.c > > > index 112799b..ba06102 100644 > > > --- a/drivers/scsi/megaraid/megaraid_sas_base.c > > > +++ b/drivers/scsi/megaraid/megaraid_sas_base.c > > > @@ -5134,9 +5134,10 @@ megasas_resume(struct pci_dev *pdev) > > > goto fail_ready_state; > > > > > > /* Now re-enable MSI-X */ > > > - if (instance->msix_vectors) > > > - pci_enable_msix(instance->pdev, instance->msixentry, > > > - instance->msix_vectors); > > > + if (instance->msix_vectors && > > > + pci_enable_msix(instance->pdev, instance->msixentry, > > > + instance->msix_vectors)) > > > + goto fail_reenable_msix; > > > > > > switch (instance->pdev->device) { > > > case PCI_DEVICE_ID_LSI_FUSION: > > > @@ -5245,6 +5246,7 @@ fail_init_mfi: > > > > > > fail_set_dma_mask: > > > fail_ready_state: > > > +fail_reenable_msix: > > > > > > pci_disable_device(pdev); > > > > > > -- > > > 1.7.7.6 > > > > > > > -- > > Regards, > > Alexander Gordeev > > agordeev@xxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
