Yeah, we thought about that one. We call scsi_activate_tcq if our scsi_device has tagged_supported set within hpsa_change_queue_type (our .change_queue_type entry into the scsi_host_template). Also made sure I was booting with the "scsi_mod.use_blk_mq=Y" option, which makes no difference either way. -----Original Message----- From: hch@xxxxxxxxxxxxx [mailto:hch@xxxxxxxxxxxxx] Sent: Tuesday, August 05, 2014 2:28 PM To: Handzik, Joe Cc: hch@xxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; scameron@xxxxxxxxxxxxxxxxxx; Scales, Webb; Teel, Scott Stacy Subject: Re: Bad tag value in scsi-mq.4 On Tue, Aug 05, 2014 at 06:04:07PM +0000, Handzik, Joe wrote: > Hey Christoph, > > Using the scsi-mq.4 branch from git://git.infradead.org/users/hch/scsi.git, I'm getting a -1 returned from from scsi_cmnd->request->tag...very unsure why that would be. It happens without any drives attached to the controller, not sure if that's relevant in any way. You're using the non-mq code path, in which tagging needs to be enabled, does your driver call scsi_activate_tcq? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
