any comments?
Thanks.
On 07/24/14 11:07, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Fix printk format warnings (seen on i386 builds):
>
> ../drivers/scsi/u14-34f.c: In function 'port_detect':
> ../drivers/scsi/u14-34f.c:630:28: warning: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'u64' [-Wformat=]
> ../drivers/scsi/u14-34f.c: In function 'u14_34f_queuecommand_lck':
> ../drivers/scsi/u14-34f.c:1290:25: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 6 has type 'int' [-Wformat=]
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: "James E.J. Bottomley" <JBottomley@xxxxxxxxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> ---
> drivers/scsi/u14-34f.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-next-20140724/drivers/scsi/u14-34f.c
> ===================================================================
> --- linux-next-20140724.orig/drivers/scsi/u14-34f.c
> +++ linux-next-20140724/drivers/scsi/u14-34f.c
> @@ -1006,7 +1006,7 @@ static int port_detect \
> sh[j]->irq, dma_name, sh[j]->sg_tablesize, sh[j]->can_queue);
>
> if (sh[j]->max_id > 8 || sh[j]->max_lun > 8)
> - printk("%s: wide SCSI support enabled, max_id %u, max_lun %u.\n",
> + printk("%s: wide SCSI support enabled, max_id %u, max_lun %llu.\n",
> BN(j), sh[j]->max_id, sh[j]->max_lun);
>
> for (i = 0; i <= sh[j]->max_channel; i++)
> @@ -1285,7 +1285,7 @@ static int u14_34f_queuecommand_lck(stru
> cpp->cpp_index = i;
> SCpnt->host_scribble = (unsigned char *) &cpp->cpp_index;
>
> - if (do_trace) printk("%s: qcomm, mbox %d, target %d.%d:%llu.\n",
> + if (do_trace) printk("%s: qcomm, mbox %d, target %d.%d:%u.\n",
> BN(j), i, SCpnt->device->channel, SCpnt->device->id,
> (u8)SCpnt->device->lun);
>
> --
--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
