Acked-By: Nilesh Javali <nilesh.javali@xxxxxxxxxx> -----Original Message----- From: Maurizio Lombardi [mailto:mlombard@xxxxxxxxxx] Sent: Monday, July 28, 2014 6:25 PM To: Vikas Chaudhary Cc: Dept-Eng iSCSI Driver; linux-scsi; James.Bottomley@xxxxxxxxxxxxxxxxxxxxx; hch@xxxxxx Subject: [PATCH] qla4xxx: check the return value of dma_alloc_coherent() the qla4xxx_alloc_fw_dump() calls dma_alloc_coherent() but does not check its return value. Signed-off-by: Maurizio Lombardi <mlombard@xxxxxxxxxx> --- drivers/scsi/qla4xxx/ql4_init.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/scsi/qla4xxx/ql4_init.c b/drivers/scsi/qla4xxx/ql4_init.c index 6f12f85..4180d6d 100644 --- a/drivers/scsi/qla4xxx/ql4_init.c +++ b/drivers/scsi/qla4xxx/ql4_init.c @@ -334,6 +334,12 @@ void qla4xxx_alloc_fw_dump(struct scsi_qla_host *ha) /* Allocate memory for saving the template */ md_tmp = dma_alloc_coherent(&ha->pdev->dev, ha->fw_dump_tmplt_size, &md_tmp_dma, GFP_KERNEL); + if (!md_tmp) { + ql4_printk(KERN_INFO, ha, + "scsi%ld: Failed to allocate DMA memory\n", + ha->host_no); + return; + } /* Request template */ status = qla4xxx_get_minidump_template(ha, md_tmp_dma); -- Maurizio Lombardi
<<attachment: winmail.dat>>
