>>>>> "Christoph" == Christoph Hellwig <hch@xxxxxx> writes: Christoph> Avoid taking the host-wide host_lock to check the per-host Christoph> queue limit. Instead we do an atomic_inc_return early on to Christoph> grab our slot in the queue, and if nessecary decrement it Christoph> after finishing all checks. More nitpicking. In the two previous atomic conversion patches you kept %hu for the atomic_t. Here it's %d. +static ssize_t +sdev_show_device_busy(struct device *dev, struct device_attribute *attr, + char *buf) +{ + struct scsi_device *sdev = to_scsi_device(dev); + return snprintf(buf, 20, "%d\n", atomic_read(&sdev->device_busy)); +} +static DEVICE_ATTR(device_busy, S_IRUGO, sdev_show_device_busy, NULL); Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx> -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html