>>>>> "Bart" == Bart Van Assche <bvanassche@xxxxxxx> writes: Bart> Sorry for the late reply but it's only now that I noticed this Bart> patch. Are you sure that presence of a NAA descriptor is Bart> mandatory ? This is what I found in SPC-4 r37 paragraph 7.8.6.2.1: Bart> <quote> At least one designation descriptor should have the Bart> DESIGNATOR TYPE field set to: Bart> a) 2h (i.e., EUI-64-based); Bart> b) 3h (i.e., NAA); or Bart> c) 8h (i.e., SCSI name string). Bart> </quote> Bart> I think this means that presence of one of these three types of Bart> descriptors is sufficient in order to be compliant with SPC-4. That's correct and bad wording on my part. It's not mandatory in the SPC sense. But the subset of the copy offload spec that vendors have generally agreed on makes NAA a requirement. You have a good point, however, and I'll tweak the code to make sure we support 2h and 8h as well. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
