On Mon, Jul 7, 2014 at 8:49 PM, Tomas Henzl <thenzl@xxxxxxxxxx> wrote:
> The driver checks the return valu, but after he tries to wait_for_completion
> which might never happen.
> Also the ioctlbuffer is freed at the end of the function,
> so the first removal is not needed.
Looks good. Thanks Tomas.
Acked-by: Suresh Thiagarajan<Suresh.Thiagarajan@xxxxxxxx>
>
> Signed-off-by: Tomas Henzl <thenzl@xxxxxxxxxx>
> ---
> drivers/scsi/pm8001/pm8001_ctl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c
> index 211ffd6..e9753bd 100644
> --- a/drivers/scsi/pm8001/pm8001_ctl.c
> +++ b/drivers/scsi/pm8001/pm8001_ctl.c
> @@ -617,11 +617,11 @@ static int pm8001_update_flash(struct pm8001_hba_info *pm8001_ha)
>
> pm8001_ha->nvmd_completion = &completion;
> ret = PM8001_CHIP_DISP->fw_flash_update_req(pm8001_ha, payload);
> + if (ret)
> + break;
> wait_for_completion(&completion);
> - if (ret || (fwControl->retcode > FLASH_UPDATE_IN_PROGRESS)) {
> + if (fwControl->retcode > FLASH_UPDATE_IN_PROGRESS) {
> ret = fwControl->retcode;
> - kfree(ioctlbuffer);
> - ioctlbuffer = NULL;
> break;
> }
> }
> --
> 1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
