> Did you plan to change the arguments to ufshcd_is_device_present in a later patch? I guess I overlooked it, thanks for bringing it to my attention. I will resend the series without this patch. Thanks, Dolev -- QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -----Original Message----- From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx] Sent: Monday, July 07, 2014 1:37 PM To: Dolev Raviv Cc: James.Bottomley@xxxxxxxxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; linux-scsi-owner@xxxxxxxxxxxxxxx; sthumma@xxxxxxxxxxxxxx; linux-arm-msm@xxxxxxxxxxxxxxx; santoshsy@xxxxxxxxx Subject: Re: [PATCH 3/3] scsi: ufs: retry if the link-startup fails This produces a compiler warning for me that looks serious: ../drivers/scsi/ufs/ufshcd.c: In function ‘ufshcd_link_startup’: ../drivers/scsi/ufs/ufshcd.c:1938:3: warning: passing argument 1 of ‘ufshcd_is_device_present’ makes integer from pointer without a cast [enabled by default] ../drivers/scsi/ufs/ufshcd.c:185:19: note: expected ‘u32’ but argument is of type ‘struct ufs_hba *’ Did you plan to change the arguments to ufshcd_is_device_present in a later patch? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
