On 07/07/2014 12:11 PM, Christoph Hellwig wrote:
On Mon, Jul 07, 2014 at 12:05:04PM +0200, Hannes Reinecke wrote:
Ok, so I'll be sending a patchset for fixing up the build warnings
(and keeping the current accesses to ->lun), and prepare a different
patchset moving everything onto accessors so that we can use struct scsi_lun
directly.
Agreed?
That would be my preference, yes.
Btw, re the build warnings: what's the reason you prefer casts to u8
over just using the %lld printk specifier? Avoiding casts generally
seems to be the cleaner variant to me.
Yeah, I've been a bit inconsistent here.
In general I've been using 'u8' casts for the older SCSI parallel
drivers, on the grounds they'll never be seeing any LUN numbers
higher than that and I don't have to modify the printk output here.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@xxxxxxx +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
