Hi, On 07/07/2014 12:10 PM, Christoph Hellwig wrote: > On Sun, Jul 06, 2014 at 02:24:03PM +0200, Hans de Goede wrote: >> Hi, >> >> On 07/03/2014 08:01 AM, Christoph Hellwig wrote: >>> Hi Hans, >>> >>> please test the path below: >> >> Note, I did a similar patch a while back, but then it was decided to >> try and fix the tear-down ordering instead (which seems to have not >> completely fixed the issue). > > I can't see any sensible way to "fix" the issue. Struct gendisk keeps a > reference to the requeue_queue, and a struct gendisk reference is held > as long as the block device is open. So whenever you surprise remove a > device that is open (usually by having a filesystem mounted on it), > the request_queue and it's reference to the tag structure will vastly > outlive the Scsi_Host. Ok, so can we then please move forward with getting your patch merged ? Thanks, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html