Re: [PATCH] scsi: break from queue depth adjusting loops when device found

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/03/2014 07:11 PM, Christoph Hellwig wrote:
On Thu, Jul 03, 2014 at 10:05:57AM -0500, Stephen M. Cameron wrote:
From: Stephen M. Cameron <scameron@xxxxxxxxxxxxxxxxxx>

Don't loop through all the devices even after
finding the one we're looking for

The comments in the code seem to indicate that we want to modify
the queue depth for all LUNs on a given target.

Ccing Mike and Vasu as they wrote this code.

Indeed, that was the idea.
This piece of code tries to keep track of the remote port queue depth, which isn't represented at all. Thing is, each remote target has a target queue depth which can hold only so many outstanding SCSI requests. If that is full it'll return BUSY for _all_ LUNs served from that port. And the very _next_ command after the one which filled the target queue will get the BUSY status. So we need to decrease the queue depth on _all_ LUNs here to avoid starvation of individual devices.

Hence I guess this is not the correct fix.

Cheers,

Hannes
--
Dr. Hannes Reinecke		      zSeries & Storage
hare@xxxxxxx			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux