On Thu, Jul 3, 2014 at 1:18 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Mon, Jun 30, 2014 at 05:19:57PM -0700, Adam Radford wrote: >> James/linux-scsi, >> >> The following patch for megaraid_sas fixes the LD/VF affiliation policy parsing code to account for LD targetId's and Hidden LD's (not yet affiliated with any Virtual Functions). > > Hi Adam, > > this doesn't address Martins comment about removing the initial != 0 > case. And while we're at it there basically is no significant shared > code between the PlasmaFW111 and !PlasmaFW111, so split these into > two different functions. With those two levels of indentation removed > the code might actually become readable, too. > > Also please remove the "James/linux-scsi," address in the individual > patches, that's something that should just go into the cover letter, > and make sure to include all "Reviewed-by:" and "Acked-by:" tags when > resending already reviewd patches. > > Thanks, > Christoph Christoph, Thanks for your and Martin's feedback. Actually there is a missing call to megasas_get_ld_vf_affiliation() with initial = 1 that should be at the bottom of megasas_probe_one(). This got dropped inadvertently during a manual merge. I will add that and split the megasas_get_ld_vf_affiliation() function into 2 functions (as you suggested) and resubmit the patch series while including all currently received "Reviewed-by" and "Acked-by" messages for the other patches and dropping the "James/linux-scsi" text. -Adam -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
