On Wed, 2014-07-02 at 17:19 -0600, Alex Williamson wrote: > On Wed, 2014-07-02 at 15:52 -0700, James Bottomley wrote: > > On Wed, 2014-07-02 at 17:44 -0500, Mike Christie wrote: > > > On 07/02/2014 05:15 PM, Alex Williamson wrote: > > > > On Sat, 2014-06-28 at 10:47 -0700, Greg Kroah-Hartman wrote: > > > >> > 3.15-stable review patch. If anyone has any objections, please let me know. > > > >> > > > > >> > ------------------ > > > >> > > > > >> > From: Sagi Grimberg <sagig@xxxxxxxxxxxx> > > > >> > > > > >> > commit d77e65350f2d82dfa0557707d505711f5a43c8fd upstream. > > > >> > > > > >> > In case protection information exists over the wire > > > >> > iscsi header data length is required to include it. > > > >> > Use protection information aware scsi helpers to set > > > >> > the correct transfer length. > > > >> > > > > >> > In order to avoid breakage, remove iser transfer length > > > >> > checks for each task as they are not always true and > > > >> > somewhat redundant anyway. > > > >> > > > > >> > Signed-off-by: Sagi Grimberg <sagig@xxxxxxxxxxxx> > > > >> > Reviewed-by: Mike Christie <michaelc@xxxxxxxxxxx> > > > >> > Acked-by: Mike Christie <michaelc@xxxxxxxxxxx> > > > >> > Signed-off-by: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> > > > >> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > > >> > > > > >> > --- > > > >> > drivers/infiniband/ulp/iser/iser_initiator.c | 34 +++++++-------------------- > > > >> > drivers/scsi/libiscsi.c | 18 +++++++------- > > > >> > 2 files changed, 19 insertions(+), 33 deletions(-) > > > > I'm a bit late to object, but this is causing a regression for me on > > > > 3.15.3 and 3.16-rc. Using an iscsi_tcp rootfs, I'm seeing the NULL > > > > > > > > > A fix for this is in Christoph's tree. Here is the status of the patch. > > > > > > http://marc.info/?l=linux-kernel&m=140432482527273&w=2 > > > > I assume it's this fix: > > > > commit 7bafc240e126c37f60b040fa429ae4a710b88ab5 > > Author: Martin K. Petersen <martin.petersen@xxxxxxxxxx> > > Date: Tue Jun 24 16:59:35 2014 +0200 > > > > scsi: use the scsi data buffer length to extract transfer size > > > > In which case it's not marked for stable backport ... I assume it should > > be? > > Yes, that's the one. It definitely needs a 3.15 stable backport. > Thanks, > Yes. James, please mark this for v3.15.y and push to Linus ASAP. Thank you, --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
