Re: [PATCH 7/7] scsi_error: do not use command list for host reset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> @@ -771,7 +770,7 @@ static int scsi_try_host_reset(struct scsi_cmnd *scmd)
>  		if (!hostt->skip_settle_delay)
>  			ssleep(HOST_RESET_SETTLE_TIME);
>  		spin_lock_irqsave(host->host_lock, flags);
> -		scsi_report_bus_reset(host, scmd_channel(scmd));
> +		scsi_report_bus_reset(host, -1);

The old code report a bus reset for every device on the channel this
command was on, and the new one will not report anything because
scsi_report_bus_reset doesn't treat -1 as a wild card.  To keep the old
behaviour you'll have to pass a channel argument here.  It's not quite
clear to me if ->eh_host_reset_handler is only supposed to reset a
"channel" or the whole HBA, but if we want to change behavior here
it should be a separate well documented patch.

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux