On Thu, 2014-06-26 at 08:08 -0700, Christoph Hellwig wrote: > On Thu, Jun 26, 2014 at 11:04:56AM -0400, James Bottomley wrote: > > Right, but look what we do for the specials. The only difference is the > > ULD has a hook to generate the CDB. For everything else we follow the > > BLOCK_PC path, including error handling and sense data processing. > > No, we don't use the BLOCK_PC path for anything but a tiny bit of setup > code right now. We will with your patch, which will cause all kinds of > behavior change. See my last mail for the list of differences, which > includes the introduction of a major memory leak. OK, I give up, what memory leak (you don't actually mention it in your emails)? All memory handling is correctly done in unprep as far as I can tell. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html