On Jun 25, 2014, at 6:35 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Wed, Jun 25, 2014 at 01:32:39PM +0300, Sagi Grimberg wrote: >> So I tested a bidirectional command using: >> $ sg_raw --infile=/root/filex --send=1024 --request=1024 >> --outfile=/root/filex "/dev/bsg/7:0:0:0" 53 00 00 00 00 00 00 00 02 00 >> >> And I see: >> kernel: session1: iscsi_prep_scsi_cmd_pdu iscsi prep [bidirectional cid 0 sc >> ffff880468ca1e00 cdb 0x53 itt 0x16 len 1024 bidi_len 1024 cmdsn 223 win 64] >> >> This confirms what I wrote above, so AFAICT no additional fix is required >> for libiscsi wrt bidi commands support. > > Good to know. I'd really prefer just going with the fix from Martin > that I have already queued up for 3.16, and then we can have the fully > fledged out "new" scsi_transfer_length() for 3.17. > I am fine with this too. I was way off track. I was more concerned with not wanting to use multiple functions/macros to get the transfer len. That should definitely be done when there is more time. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
