On Tue, Jun 10, 2014 at 04:57:06PM -0400, Laurence Oberman wrote: > I am tired of building modules to enable SCSI tape driver debug so I > am hoping this patch is acceptable. > Tested using kernel 3.14.6 > > Usage example: > modprobe st debug_flag=1 Missing Signed-off-by :-) > +module_param_named(debug_flag, debug_flag, int, 0); It's probably not worth making this a sysfs knob as most distros still compile st as a module although why not just set debugging directly from the module parameter? > +MODULE_PARM_DESC(debug_flag, "Enable DEBUG, same as setting DEBUG 1 > in source"); > + The description is a bit misleading as a bunch of stuff gets compiled out when DEBUG is unset at compile time. Maybe "same as setting debugging=1" instead? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
