Hi Several have remarked in the other patch for strncpy I posted. That there is a strlcpy that works exactly as one would like to strncpy was done :) And the return value is like for snprintf, but quite a lot faster! So I submit patches based with it instead, and did a couple more exchanges of snprintf to strlcpy. Best regards Rickard Strandqvist 2014-06-05 9:10 GMT+02:00 Bart Van Assche <bvanassche@xxxxxxx>: > On 06/05/14 08:55, Bart Van Assche wrote: >> On 06/04/14 20:08, Rickard Strandqvist wrote: >> This is ugly. Please use sprintf(buf, "%.*s\n", PAGE_SIZE - 1, str) >> instead of strncpy() + strlen(). > > (replying to my own e-mail) > > The above should of course have read "sprintf(buf, "%.*s\n", PAGE_SIZE - > 2, str)" to avoid that the terminating '\0' triggers a buffer overflow. > > Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
