On Thu, 5 Jun 2014 02:34:29 -0700
Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> > diff --git a/drivers/message/fusion/mptsas.h b/drivers/message/fusion/mptsas.h
> > index 57e86ab..c396483 100644
> > --- a/drivers/message/fusion/mptsas.h
> > +++ b/drivers/message/fusion/mptsas.h
> > @@ -110,7 +110,7 @@ struct fw_event_work {
> > MPT_ADAPTER *ioc;
> > u32 event;
> > u8 retries;
> > - u8 __attribute__((aligned(4))) event_data[1];
> > + char event_data[0] __aligned(4);
> > };
Is this alignment necessary and if so, should it be more like:
__attribute__ ((aligned (sizeof(unsigned long))))
> >
> > - sz = offsetof(struct fw_event_work, event_data) +
> > - sizeof(MpiEventDataSasDeviceStatusChange_t);
> > + sz = sizeof(*fw_event) +
> > + sizeof(MpiEventDataSasDeviceStatusChange_t);
> > fw_event = kzalloc(sz, GFP_ATOMIC);
>
> Seems like there is no point in keeping the sz variable here and at
> the other occurances. Not that it really matters, but if we make a pass
> over this code we might as well fix that up, too.
I'll take a look and post up a v2 next week, adding these to a v2
mpt2/mpt3 set.
Thanks,
-- Joe
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
