Re: [PATCH] be2iscsi: add an missing goto in error path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Jun 6, 2014, at 7:06 AM, Tomas Henzl <thenzl@xxxxxxxxxx> wrote:

> a jump to 'free_memory' is apparently missing
> 
> Signed-off-by: Tomas Henzl <thenzl@xxxxxxxxxx>
> ---
> diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
> index ac54cf5..442982d 100644
> --- a/drivers/scsi/be2iscsi/be_main.c
> +++ b/drivers/scsi/be2iscsi/be_main.c
> @@ -4209,6 +4209,8 @@ static int hba_setup_cid_tbls(struct beiscsi_hba *phba)
> 		kfree(phba->ep_array);
> 		phba->ep_array = NULL;
> 		ret = -ENOMEM;
> +
> +		goto free_memory;
> 	}
> 
> 	for (i = 0; i < phba->params.cxns_per_ctrl; i++) {
> — 

Thanks.

Reviewed-by: Mike Christie <michaelc@xxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux