On Wed, Jun 04, 2014 at 01:34:54PM +0200, Paolo Bonzini wrote: > From: Ming Lei <tom.leiming@xxxxxxxxx> > > Access to tgt->req_vq is strictly serialized by spin_lock > of tgt->tgt_lock, so the ACCESS_ONCE() isn't necessary. > > smp_read_barrier_depends() in virtscsi_req_done was introduced > to order reading req_vq and decreasing tgt->reqs, but it isn't > needed now because req_vq is read from > scsi->req_vqs[vq->index - VIRTIO_SCSI_VQ_BASE] instead of > tgt->req_vq, so remove the unnecessary barrier. > > Also remove related comment about the barrier. Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
