On Wed, 2014-06-04 at 23:36 +0200, Rickard Strandqvist wrote: > Added a guaranteed null-terminate after call to strncpy. Next time you submit a patch series like this can you please use a cover letter? That way I can reply to the cover letter with a comment about the series instead of multiple replies to various patches. I think all of these should be using strlcpy not strncpy. > diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c [] > @@ -2097,7 +2097,8 @@ _base_display_ioc_capabilities(struct MPT2SAS_ADAPTER *ioc) > u32 bios_version; > > bios_version = le32_to_cpu(ioc->bios_pg3.BiosVersion); > - strncpy(desc, ioc->manu_pg0.ChipName, 16); > + strncpy(desc, ioc->manu_pg0.ChipName, sizeof(desc)); > + desc[sizeof(desc) - 1] = '\0'; -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
