On Fri, 30 May 2014 19:07:36 +0200
Fabian Frederick <fabf@xxxxxxxxx> wrote:
> (memdup_user can be used to replace kmalloc/copy_from_user. Not sure if it's ok with kzalloc ...)
> + kern_buf = memdup_user((void __user *)buf, nbytes);
> + if (IS_ERR(kern_buf)) {
> + printk(KERN_INFO "bfad[%d]: Failed to copy buffer\n",
> + bfad->inst_no);
While you are tidying up lose the printk KERN_INFO stuff here, it really
isn't needed.
Looks good to me and it also fixes the incorrect return of -ENOMEM the
old code had on a copy_from_user failing.
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
