Hi Quite rightly, this is what cppcheck reacts. Ok, I'll send a patch for that instead then. Best regards Rickard Strandqvist 2014-05-28 13:38 GMT+02:00 Tomas Henzl <thenzl@xxxxxxxxxx>: > On 05/28/2014 01:28 PM, Christoph Hellwig wrote: >> On Sun, May 18, 2014 at 06:14:00PM +0200, Rickard Strandqvist wrote: >>> There is otherwise a risk of a possible null pointer dereference. >>> >>> Was largely found by using a static code analysis program called cppcheck. >> I can't see how dev->lldd_dev would be NULL here. > > The analysis program likely can't know that, the reason for this report > it that dev->lldd_dev is tested for not being null several lines below - > http://lxr.free-electrons.com/source/drivers/scsi/pm8001/pm8001_hwi.c#L4447 > So the other option is to remove this^ test. > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
