Re: [PATCH] [SCSI] mpt2sas: Don't disable device twice at suspend.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 25, 2014 at 04:41:04PM -0400, Tyler Stachecki wrote:
> On suspend, _scsih_suspend calls mpt2sas_base_free_resources, which
> in turn calls pci_disable_device if the device is enabled prior to
> suspending. However, _scsih_suspend also calls pci_disable_device
> itself.
> 
> Thus, in the event that the device is enabled prior to suspending,
> pci_disable_device will be called twice. This patch removes the
> duplicate call to pci_disable_device in _scsi_suspend as it is both
> unnecessary and results in a kernel oops.
> 
> Signed-off-by: Tyler Stachecki <tstache1@xxxxxxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux