On Mon, 2014-05-26 at 13:30 -0400, Martin K. Petersen wrote: > >>>>> "Nic" == Nicholas A Bellinger <nab@xxxxxxxxxxxxxxx> writes: > > >> What about #ifdef'ing VIRTIO_SCSI_F_T10_PI support out if > >> !CONFIG_BLK_DEV_INTEGRITY? > > Nic> I figured it was slightly cleaner to enable BLK_DEV_INTEGRITY by > Nic> default when referencing struct blk_integrity (following what > Nic> IBLOCK does), than adding the equivalent #ifdef's.. > > Nic> MKP, do you have a preference on this..? > > Well, I guess how important the virtio stuff is in the embedded space? > > In the block layer we have all these wrappers that allow things to Do > The Right Thing when the BLK_DEV_INTEGRITY is disabled. I'm not entirely > sure it worth the hassle to do the same for target and virtio. The > memory savings aren't that big to begin with. > > And besides, the bip pointer field in struct bio is about to become > generic with my impending copy offload patches anyway, > In that case, I'll leave as is unless Paolo has an objection. --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
