On Wed, May 21, 2014 at 08:30:58AM +0200, Hannes Reinecke wrote: > While this works reasonably well for most things, printing out > decoded sense with just one line (and not end up in massive switch() > statements) is near impossible. > > Plus you'll end up having to use a static buffer at one point, which > again increases the stack size. > > The alternative approach as discussed at LSF is to move scsi_logging > over to tracing. There is already some coding for scsi tracing, but > in most cases it just duplicates existing logging statements. > So if we were to replace the entire scsi_logging infrastructure > with scsi tracing most of the issues (like chopped-up CDBs) would > be gone. > Plus we would have a far better control about _what_ is being printed. > > And yes, I do have some patches for that :-) I think any detailed logging of sense codes, cdbs and co should move to tracing. In fact generally any non-defauly logging probably is better off in the tracing subsystems, but there might be a few exceptions. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
