> -----Original Message----- > From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi- > owner@xxxxxxxxxxxxxxx] On Behalf Of Hannes Reinecke > Sent: Thursday, May 08, 2014 1:10 AM > To: James Bottomley > Cc: linux-scsi@xxxxxxxxxxxxxxx; Hannes Reinecke; Stephen Cameron > Subject: [PATCH] Set correct completion code in scsi_send_eh_cmnd() > > ->queuecommand returns '0' for successful command submission, > so we need to set the correct SCSI midlayer return value > when calling scsi_log_completion(). > > Reported-by: Robert Elliott <elliott@xxxxxx> > Cc: Stephen Cameron <scameron@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Hannes Reinecke <hare@xxxxxxx> > --- > drivers/scsi/scsi_error.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c > index f17aa7a..f4e0cad 100644 > --- a/drivers/scsi/scsi_error.c > +++ b/drivers/scsi/scsi_error.c > @@ -1029,6 +1029,7 @@ retry: > rtn = NEEDS_RETRY; > } else { > timeleft = wait_for_completion_timeout(&done, timeout); > + rtn = SUCCESS; > } > > shost->eh_action = NULL; > -- > 1.7.12.4 I've confirmed that patch successfully gets rid of bogus reporting of "UNKNOWN" for successfully submitted commands from that function, correcting the use of "internal return values" vs. "midlayer return values." [ 5454.381659] sd 2:0:0:1: [sds] scsi_eh_2: requesting sense [ 5454.383597] scsi_eh_done scmd: ffff880428963a70 result: 0 [ 5454.385457] sd 2:0:0:1: [sds] Done: UNKNOWN [ 5454.387430] sd 2:0:0:1: [sds] Result: hostbyte=DID_OK driverbyte=DRIVER_OK Tested-by: Robert Elliott <elliott@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
