Il 07/05/2014 18:03, Ming Lei ha scritto:
*
* - likewise, decrements of reqs only occur when reqs != 0. If the decremented
* value is zero, the first CPU that enters virtscsi_queuecommand_multi will
* modify req_vq and the others will spin on tgt_lock.
The fact should be obvious too,
Perhaps, but in your patch you're leaving a "Similarly" that doesn't
apply anymore.
> * We do not try to read req_vq locklessly for simplicity, so tgt_lock is used
> * to serialize reads of req_vq too.
Maybe it is better to just mention it isn't done yet, and maybe someone
will figure out simple way to support lockless reading req_vq.
The one I sketched is not too hard.
Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
