On 05/01/2014 02:21 PM, Nicholas A. Bellinger wrote:
So now that target code (plus Sagi's patches) is finally working correctly with active I/O shutdown with iser + friends, I'm not exactly crazy about introducing a bunch of changes that potentially break long standing assumptions about how se_lun + se_dev_entry pointers are accessed.
This saves a huge amount of wasted memory per nodeacl and per tpg. It's a net reduction of 120 lines of code.
If you wanted to push the iser work to Linus by itself, maybe this goes into your tree immediately after that? That would give it plenty of time in your tree before it went upstream.
That said, I'd much rather see proper percpu refcounting for se_dev_entry introduced ahead of these types of memory space related optimizations.
These patches are not refcount-related, so they should be orthogonal to any refcount improvements.
I think the set from March 24 should still apply, but I'm happy to re-send or post a repo if that would be helpful to you.
Regards -- Andy -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
