On Fri, Apr 25, 2014 at 3:49 PM, David Rientjes <rientjes@xxxxxxxxxx> wrote: > > Hmm, I see why this is needed because of the scsi_put_command(cmd), but I > think you need to do struct scsi_device *sdev = ACCESS_ONCE(cmd->device) > instead to prevent gcc from messing with the code generation. No, if gcc were to move the access to 'cmd' to after the 'scsi_put_command(cmd)', that would be a major compiler bug. Compilers can't just randomly move code around, guys. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html